Lightbox doesn't close on flagging author image

ConversesBug Collectors

Afegeix-te a LibraryThing per participar.

Lightbox doesn't close on flagging author image

1Nevov
març 28, 2023, 11:55 am

I've just placed a flag on an author pic, but the lightbox didn't vanish when I had written the comment and hit "Post comment". The flag did go through, just I had to manually close the lightbox when previously it would vanish automatically.

To replicate:
1. find an author photo to flag (or deliberately upload a duplicate/wrong image to test this bug)
2. go to "Flag image" underneath the image
3. in the "Please explain your reasons for flagging" lightbox, write the reason, and hit "Post comment"
The bug: previously the lightbox would vanish at this step, but it now doesn't.

2Nevov
març 28, 2023, 11:59 am

Possibly worth mentioning: there was some work done recently to fix a bug with flags not counting towards a badge, wondering if that fix has thrown something out: https://www.librarything.com/topic/228729#8097070

3kristilabrie
Editat: març 29, 2023, 8:24 am

Verified:

1. go to https://www.librarything.com/pic/9800444
2. click "Flag Image"
3. Enter a comment like, "Not a picture of the author."
4. click the "Post Comment" button.

Bug: The lightbox doesn't close unless you manually click the "x".

5. Refresh the page: the comment and flag are there.

4Nevov
abr. 12, 2023, 10:21 pm

Just a theory: I've flagged several (four?) pictures since posting this bug, and noticed that my stat for flags placed isn't incrementing, neither at the point of placing the flag nor at the point that the vote implements and removes the picture. The topic link in >2 Nevov:, Tim mentions that work was done to change how the site counted flags placed. Could be (theory): that at the moment of placing a flag via pressing "Post Comment", the site tries to do something to count the flag to the flagger, but fails, causing this bug with the lightbox remaining present because it can't complete what it is trying to do.

Let me know if that warrants a separate topic for "placing a picture flag doesn't increment the stat", or if you prefer to have all of this kept together here as it could be simply different symptoms of the same bug.

5kristilabrie
abr. 13, 2023, 9:01 am

>4 Nevov: Hmm, I think keep here for now since it's related and I'll ping conceptDawg about it in case it's useful! Thanks!

6rodneyvc
maig 5, 2023, 7:47 am

>3 kristilabrie: Bump - this happened to me when flagging https://www.librarything.com/pic/9886215

7lemontwist
jul. 10, 2023, 7:22 am

bump

8lilithcat
març 4, 1:17 pm